This repository was archived by the owner on Feb 25, 2025. It is now read-only.
System mouse cursor: macOS#18131
Merged
dkwingsmt merged 18 commits intoMay 20, 2020
Merged
Conversation
stuartmorgan-g
suggested changes
May 7, 2020
| FlutterDartProject* _project; | ||
|
|
||
| // The plugin used to handle mouse cursor. This is not an FlutterPlugin, so must be owned | ||
| // separately. |
Contributor
There was a problem hiding this comment.
Per the other comment I don't think this is true, in which case you wouldn't need an ivar for it.
stuartmorgan-g
suggested changes
May 11, 2020
stuartmorgan-g
approved these changes
May 20, 2020
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Contributor
There was a problem hiding this comment.
LGTM with comment nits!
17 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
* Untested macOS impl * Workable mac * Modernize * Simplify * Address comments * Refactor with FlutterPlugin * Cached dict * Update per comments * format * Remove device arg * Format * Update license * Update licences * Doc update
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2020
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
May 26, 2020
Roll Engine from 9ce1e5c to 1a83498 (69 revisions) flutter-team-archive/engine@9ce1e5c...1a83498 2020-05-26 hterkelsen@users.noreply.github.com Revert "Update CanvasKit to 0.15.0 (flutter#18570)" (flutter-team-archive/engine#18600) 2020-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from TSEOq... to hr-HZ... (flutter-team-archive/engine#18594) 2020-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 65113fd73dec to 9e3b0289197d (2 revisions) (flutter-team-archive/engine#18593) 2020-05-26 skia-flutter-autoroll@skia.org Roll Skia from b6d158aaf3dd to e4b4ca1050b9 (1 revision) (flutter-team-archive/engine#18592) 2020-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DzG49... to pLp67... (flutter-team-archive/engine#18591) 2020-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Oz016... to TSEOq... (flutter-team-archive/engine#18590) 2020-05-23 skia-flutter-autoroll@skia.org Roll Skia from afd8a6c6ae87 to b6d158aaf3dd (3 revisions) (flutter-team-archive/engine#18588) 2020-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 99Z4_... to Oz016... (flutter-team-archive/engine#18582) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from ec31488ace66 to afd8a6c6ae87 (1 revision) (flutter-team-archive/engine#18581) 2020-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Kvwlr... to DzG49... (flutter-team-archive/engine#18580) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from 80abb89c3632 to ec31488ace66 (1 revision) (flutter-team-archive/engine#18579) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from da90c3765908 to 80abb89c3632 (4 revisions) (flutter-team-archive/engine#18577) 2020-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _zNmv... to 99Z4_... (flutter-team-archive/engine#18576) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from 317dce5c81c0 to da90c3765908 (1 revision) (flutter-team-archive/engine#18575) 2020-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ee57c08e0a6 to 65113fd73dec (3 revisions) (flutter-team-archive/engine#18574) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from 67e21a19259b to 317dce5c81c0 (3 revisions) (flutter-team-archive/engine#18573) 2020-05-22 hterkelsen@users.noreply.github.com Update CanvasKit to 0.15.0 (flutter-team-archive/engine#18570) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 3d52abc84667 to 67e21a19259b (1 revision) (flutter-team-archive/engine#18568) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 396b5fb7a97d to 4ee57c08e0a6 (6 revisions) (flutter-team-archive/engine#18567) 2020-05-21 robert.ancell@canonical.com Add fl_value_to_string (flutter-team-archive/engine#18540) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 1e63279156d6 to 3d52abc84667 (5 revisions) (flutter-team-archive/engine#18566) 2020-05-21 chris@bracken.jp null-annotate semantics.dart (flutter-team-archive/engine#18553) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ciqRH... to Kvwlr... (flutter-team-archive/engine#18565) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from b37105ea6cca to 1e63279156d6 (9 revisions) (flutter-team-archive/engine#18564) 2020-05-21 gw280@google.com Implement WriteAtomically using write/fsync on all platforms, and enable (flutter-team-archive/engine#18320) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from ecce58c1e354 to 396b5fb7a97d (2 revisions) (flutter-team-archive/engine#18560) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RNByJ... to _zNmv... (flutter-team-archive/engine#18558) 2020-05-21 st.krwlng@gmail.com [profiling] Memory Profiling support for iOS (flutter-team-archive/engine#18516) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 22636205ce92 to b37105ea6cca (2 revisions) (flutter-team-archive/engine#18557) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d551980ac9fc to ecce58c1e354 (2 revisions) (flutter-team-archive/engine#18556) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from bf7e9d13d730 to d551980ac9fc (6 revisions) (flutter-team-archive/engine#18551) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 4c0578632217 to 22636205ce92 (4 revisions) (flutter-team-archive/engine#18550) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ThMeW... to ciqRH... (flutter-team-archive/engine#18549) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 67ff541ac116 to 4c0578632217 (1 revision) (flutter-team-archive/engine#18547) 2020-05-21 xster@google.com Let run_tests.py just stream output (flutter-team-archive/engine#18534) 2020-05-21 robert.ancell@canonical.com Add FlKeyEventPlugin (flutter-team-archive/engine#18313) 2020-05-21 mehmetf@users.noreply.github.com Add tests for StandardMethodCodec (flutter-team-archive/engine#18521) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from f83baf230c69 to 67ff541ac116 (1 revision) (flutter-team-archive/engine#18545) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3o9aQ... to RNByJ... (flutter-team-archive/engine#18543) 2020-05-21 dworsham@google.com fuchsia: Fix runtime_tests and shell_tests (flutter-team-archive/engine#18492) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from d2dc8ddcdf5e to f83baf230c69 (2 revisions) (flutter-team-archive/engine#18539) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 7aa8656d1dd8 to bf7e9d13d730 (21 revisions) (flutter-team-archive/engine#18538) 2020-05-21 robert.ancell@canonical.com Add FlMethodChannel, FlMethodCodec, FlStandardMethodCodec and FlJsonMethodCodec (flutter-team-archive/engine#18220) 2020-05-20 ferhat@gmail.com [web] Fix arc rendering when it starts a new sub path. (flutter-team-archive/engine#18535) 2020-05-20 garyq@google.com Send platformResolvedLocale from iOS embedder (flutter-team-archive/engine#18519) 2020-05-20 dkwingsmt@users.noreply.github.com System mouse cursor: macOS (flutter-team-archive/engine#18131) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds system mouse cursor to the macOS engine.
This PR adds only a limited pool of system cursors. More will be added when the system is set up.
Related Issues